Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: pin to cython_0 #302358

Merged
merged 2 commits into from
Apr 18, 2024
Merged

ceph: pin to cython_0 #302358

merged 2 commits into from
Apr 18, 2024

Conversation

danielbarter
Copy link
Contributor

@danielbarter danielbarter commented Apr 7, 2024 •
edited
Loading

Description of changes

Downgrading cython since ceph does not build with cython v3. Fixes #302224

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@danielbarter danielbarter mentioned this pull request Apr 7, 2024
Closed
@ofborg ofborg bot requested a review from adevress April 7, 2024 15:23
@mweinelt
Copy link
Member

Ceph is cached for me on master. Is this still relevant?

@danielbarter
Copy link
Contributor Author

danielbarter commented Apr 18, 2024 •
edited
Loading

@mweinelt: just checked, and still seeing the same error on staging-next, so probably gonna be hitting master in the next few days

@mweinelt mweinelt marked this pull request as draft April 18, 2024 09:07
@mweinelt mweinelt changed the base branch from staging to staging-next April 18, 2024 09:07
@mweinelt mweinelt marked this pull request as ready for review April 18, 2024 09:08
@mweinelt mweinelt changed the title ceph: build broken with cython v3 ceph: pin to cython_0 Apr 18, 2024
@mweinelt mweinelt merged commit 40b1df8 into NixOS:staging-next Apr 18, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

@krav krav Awaiting requested review from krav

@johanot johanot Awaiting requested review from johanot

@dotlambda dotlambda Awaiting requested review from dotlambda

@adevress adevress Awaiting requested review from adevress

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbarter @mweinelt